[webkit-reviews] review granted: [Bug 130078] [GTK] Use GMainLoopSource for idle and timeout sources in WebCore : [Attachment 227271] Try to fix the build

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 130078: [GTK] Use GMainLoopSource for idle and timeout sources in WebCore
https://bugs.webkit.org/show_bug.cgi?id=130078

Attachment 227271: Try to fix the build
https://bugs.webkit.org/attachment.cgi?id=227271&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227271&action=review


> Source/WebCore/ChangeLog:8
> +	   * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

All this can be removed if you don't plan to comment each change :)

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-145

> -    // Reset pipeline if we are sitting on READY state when timeout is
reached

Can this comment be kept in the new code please?

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:33

> +#include <wtf/gobject/GMainLoopSource.h>

Can the class be forward-declared instead?