[webkit-reviews] review granted: [Bug 130494] EmptyUnique strings are Identifiers/Atomic : [Attachment 227249] Fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 130494: EmptyUnique strings are Identifiers/Atomic
https://bugs.webkit.org/show_bug.cgi?id=130494

Attachment 227249: Fix
https://bugs.webkit.org/attachment.cgi?id=227249&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227249&action=review


r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   This fixes a unreproducible bug we believe exists in Identifier
handling.

"an"

> Source/JavaScriptCore/ChangeLog:13
> +	   through the main Identifier constructor, the Identifier flags is not
set

"flag"

> Source/JavaScriptCore/ChangeLog:20
> +	   by-id (cachable) accesses to PrivateNames the we can end up passing
an

s/the we/we/

> Source/WTF/wtf/text/StringStatics.cpp:63
> +    } while (!(s_nextHashAndFlagsForEmptyUnique >> s_flagCount));

You could do away with this loop by just OR'ing a 1 into the top bit. Top bits
never get used, anyway.