[webkit-reviews] review granted: [Bug 130491] Merge Misc. WebVTT Updates from Blink : [Attachment 227240] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 19 18:29:03 PDT 2014
Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 130491: Merge Misc. WebVTT Updates from Blink
https://bugs.webkit.org/show_bug.cgi?id=130491
Attachment 227240: Patch
https://bugs.webkit.org/attachment.cgi?id=227240&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227240&action=review
> Source/WebCore/html/track/VTTCue.cpp:989
> // NOTE: toInt ignores trailing non-digit characters, such as
'%'.
This comment is no longer necessary because we don't use toInt.
> LayoutTests/ChangeLog:31
> + * media/track/track-webvtt-tc027-empty-cue-expected.txt: Marke one
test as expected to fail, since
Nit: "Marke"
More information about the webkit-reviews
mailing list