[webkit-reviews] review granted: [Bug 130153] Subpixel rendering: Nested layers with subpixel accumulation paint to wrong position. : [Attachment 227145] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 130153: Subpixel rendering: Nested layers with subpixel accumulation paint
to wrong position.
https://bugs.webkit.org/show_bug.cgi?id=130153

Attachment 227145: Patch
https://bugs.webkit.org/attachment.cgi?id=227145&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227145&action=review


> Source/WebCore/rendering/RenderLayer.cpp:4176
> +    // Translate the graphics context to the snapping position to avoid
off-device-pixel positing. This works as long as the user defined
> +    // transform is not producing subpixel results (translate(0.5px, 0.5px)
vs. translate(0.7px, 0.7px))

"This works as long as" isn't really adding information here, and it's not
clear what "works" means. I'd remove this second sentence.