[webkit-reviews] review granted: [Bug 130437] Filter out editable services from image menu for non-contenteditable images : [Attachment 227188] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 19 12:18:21 PDT 2014


Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 130437: Filter out editable services from image menu for
non-contenteditable images
https://bugs.webkit.org/show_bug.cgi?id=130437

Attachment 227188: Patch v1
https://bugs.webkit.org/attachment.cgi?id=227188&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227188&action=review


> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:55
> +- (instancetype)initWithImage:(NSImage *)image
includeEditorServices:(BOOL)includeEditorServices
menuClient:(WebContextMenuClient*)menuClient

Is the list of things to exclude likely to expand? If so, we might want to
consider doing something different here.


More information about the webkit-reviews mailing list