[webkit-reviews] review granted: [Bug 130406] Fix cue rendering test and include support for left/right alignment. : [Attachment 227204] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 19 11:34:08 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 130406: Fix cue rendering test and include support for left/right
alignment.
https://bugs.webkit.org/show_bug.cgi?id=130406

Attachment 227204: Patch
https://bugs.webkit.org/attachment.cgi?id=227204&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227204&action=review


> Source/WebCore/html/track/VTTCue.cpp:618
> +    } else {
> +	   ASSERT_NOT_REACHED();
>      }

Nit: I don't think the braces are necessary.


More information about the webkit-reviews mailing list