[webkit-reviews] review granted: [Bug 130360] [iOS] WebKit2 Quicklook. : [Attachment 227165] Build fix for gtk port.

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 130360: [iOS] WebKit2 Quicklook.
https://bugs.webkit.org/show_bug.cgi?id=130360

Attachment 227165: Build fix for gtk port.
https://bugs.webkit.org/attachment.cgi?id=227165&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227165&action=review


Sam gives his blessing as well, but bugzilla is not cooperating for him.

> Source/WebCore/platform/network/ios/QuickLook.mm:399
> +	   return adoptPtr(new QuickLookHandle(NULL, nil, response, delegate));


nullptr for the first arg, which is a C++ type?

> Source/WebKit2/WebProcess/ios/WebResourceLoaderIOS.mm:45
> +-
(id)initWithWebResourceLoader:(PassRefPtr<WebKit::WebResourceLoader>)loader

instancetype for the return value?