[webkit-reviews] review granted: [Bug 130441] WebKit2 View Gestures: Swipe gesture can track vertical movement instead of horizontal movement : [Attachment 227152] patch that builds
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 19 10:44:53 PDT 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 130441: WebKit2 View Gestures: Swipe gesture can track vertical movement
instead of horizontal movement
https://bugs.webkit.org/show_bug.cgi?id=130441
Attachment 227152: patch that builds
https://bugs.webkit.org/attachment.cgi?id=227152&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227152&action=review
> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:267
> if (!event.hasPreciseScrollingDeltas)
> return false;
>
> if (![NSEvent isSwipeTrackingFromScrollEventsEnabled])
> return false;
Would be cheaper to do these early returns sooner.
> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:279
> + m_hasPendingSwipe = false;
Does this need to be cleared before the previous return?
More information about the webkit-reviews
mailing list