[webkit-reviews] review granted: [Bug 129853] Move to using std::unique_ptr for EFL objects. : [Attachment 227179] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Hyowon Kim
<hw1008.kim at samsung.com>'s request for review:
Bug 129853: Move to using std::unique_ptr for EFL objects.
https://bugs.webkit.org/show_bug.cgi?id=129853

Attachment 227179: Patch
https://bugs.webkit.org/attachment.cgi?id=227179&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227179&action=review


> Source/WTF/wtf/efl/UniquePtrEfl.h:35
> +    void operator()(T* ptr) const { ASSERT_NOT_REACHED(); }

I think  you can mark this = delete; instead to get a compile error instead of
a runtime error.

> Source/WebCore/platform/graphics/efl/EvasGLContext.h:44
> +	   return std::unique_ptr<EvasGLContext>(new EvasGLContext(evasGL,
context));

This can use std::make_unique.

> Source/WebCore/platform/graphics/efl/EvasGLSurface.h:53
> +	   return std::unique_ptr<EvasGLSurface>(new EvasGLSurface(evasGL,
surface));

std::make_unique.

> Tools/DumpRenderTree/efl/DumpRenderTree.cpp:474
> +    ecoreEvas.reset();

= nullptr;

> Tools/ImageDiff/efl/ImageDiff.cpp:363
> +    gEcoreEvas.reset(); // Make sure ecore_evas_free is called before the
EFL are shut down

= nullptr.