[webkit-reviews] review requested: [Bug 129098] WebKit crashes during execution of ReplaceSelectionCommand : [Attachment 227173] [test] Proposed patch

[bugzilla-daemon at webkit.org]

Rob Płóciennik <r.plociennik at samsung.com> has asked  for review:
Bug 129098: WebKit crashes during execution of ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=129098

Attachment 227173: [test] Proposed patch
https://bugs.webkit.org/attachment.cgi?id=227173&action=review

------- Additional Comments from Rob Płóciennik <r.plociennik at samsung.com>
The following patch, instead of undoing the whole command, attempts to avoid
inserting unmovable forbidden child nodes while executing the
ReplaceSelectionCommand, using a method derived from existing code.
This approach has been chosen (instead of removing the offending nodes /after/
inserting them) to prevent the registration of undo steps for commands that
have no effect. This behavior has been highlighted in a new test.