[webkit-reviews] review requested: [Bug 130241] Refactor checking log channel state in MediaPlayerPrivateGStreamerBase. : [Attachment 227168] patch

[bugzilla-daemon at webkit.org]

Peter Molnar <pmolnar.u-szeged at partner.samsung.com> has asked  for review:
Bug 130241: Refactor checking log channel state in
MediaPlayerPrivateGStreamerBase.
https://bugs.webkit.org/show_bug.cgi?id=130241

Attachment 227168: patch
https://bugs.webkit.org/attachment.cgi?id=227168&action=review

------- Additional Comments from Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>
(In reply to comment #7)
> (From update of attachment 226902 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=226902&action=review
> 
> This is basically good but the logChannelEnabled local variable can easily be
avoided, we like early returns in WebKit :)

Thank you for the correction, it looks nicer indeed :)

> 
> > Source/WebCore/platform/Logging.cpp:53
> > +	 if (channel)
> 
> This can be transformed to an early return: if (!channel) return false;
> 
> and then below return channel->state != WTFLogChannelOff;
> So no need for a local variable