[webkit-reviews] review granted: [Bug 130433] Add new functionality that will be required by the history item decoding : [Attachment 227132] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 18 19:36:13 PDT 2014


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 130433: Add new functionality that will be required by the history item
decoding
https://bugs.webkit.org/show_bug.cgi?id=130433

Attachment 227132: Patch
https://bugs.webkit.org/attachment.cgi?id=227132&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227132&action=review


> Source/WebCore/platform/KeyedCoding.h:79
> +	   // FIXME: This doesn't distinguish between a missing object
dictionary or a value of a different type.

This took me a bit to parse.  I would add a little bit more information about
how its beginObject() doesn't distinguish and why return true.


More information about the webkit-reviews mailing list