[webkit-reviews] review denied: [Bug 130360] [iOS] WebKit2 Quicklook. : [Attachment 226976] Fixed a conflict in WebKit2.xcodeproj/project.pbxproj.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 130360: [iOS] WebKit2 Quicklook.
https://bugs.webkit.org/show_bug.cgi?id=130360

Attachment 226976: Fixed a conflict in WebKit2.xcodeproj/project.pbxproj.
https://bugs.webkit.org/attachment.cgi?id=226976&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226976&action=review


>> Source/WebKit2/WebProcess/ios/WebResourceLoaderIOS.h:35
>> +class WebResourceLoaderIOS : public WebResourceLoader {
> 
> this class can be 'final'

I am not sure it is worth subclassing here.  I would just throw the QuickLook
stuff right into WebResourceLoader.  I assume you didn't do that because the
QuickLook stuff uses Objective-C. To get around that, I would add an C++
wrapper class (like we do for the content filtering stuff with the
WebCore::ContentFilter class.