[webkit-reviews] review granted: [Bug 130427] [iOS][WebKit2] Mark layer contents as being opaque if they are : [Attachment 227141] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 130427: [iOS][WebKit2] Mark layer contents as being opaque if they are
https://bugs.webkit.org/show_bug.cgi?id=130427

Attachment 227141: patch
https://bugs.webkit.org/attachment.cgi?id=227141&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227141&action=review


> Source/WebCore/platform/graphics/GraphicsLayerClient.h:91
> +    virtual bool willPaintOpaqueAtNonIntegralScale(const GraphicsLayer*)
const { return false; }

This sounds like it only applies to the next paint. Maybe
paintsOpaquelyAtNonIntegralScales?

> Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h:84
> +    RetainPtr<CGImageRef> image() const;

Does this actually need to return a RetainPtr?