[webkit-reviews] review granted: [Bug 130260] [GTK][CMake] Add support for building with Clang : [Attachment 226933] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 18 13:45:49 PDT 2014
Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 130260: [GTK][CMake] Add support for building with Clang
https://bugs.webkit.org/show_bug.cgi?id=130260
Attachment 226933: Patch
https://bugs.webkit.org/attachment.cgi?id=226933&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226933&action=review
> Source/cmake/OptionsCommon.cmake:40
> + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Qunused-arguments")
> + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Qunused-arguments")
> +endif ()
Small nit. There's an extra space after FLAGS in both of these.
More information about the webkit-reviews
mailing list