[webkit-reviews] review granted: [Bug 130351] LayoutBox is a terrible name : [Attachment 227088] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 130351: LayoutBox is a terrible name
https://bugs.webkit.org/show_bug.cgi?id=130351

Attachment 227088: Patch
https://bugs.webkit.org/attachment.cgi?id=227088&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227088&action=review


> Source/WebCore/rendering/shapes/Shape.h:72
> -    static PassOwnPtr<Shape> createLayoutBoxShape(const RoundedRect&,
WritingMode, Length margin, Length padding);
> +    static PassOwnPtr<Shape> createBoxShape(const RoundedRect&, WritingMode,
Length margin, Length padding);

Not sure that "box shape" makes sense here, since you're not passing a
CSSBoxType parameter.

> Source/WebCore/rendering/style/RenderStyleConstants.h:559
> +enum CSSBoxType { BoxMissing = 0, MarginBox, BorderBox, PaddingBox,
ContentBox, Fill, Stroke, ViewBox };

This patch makes me wonder if we should call this a CSSReferenceBox