[webkit-reviews] review granted: [Bug 130165] RenderTextControl depends on OS X-specific behavior : [Attachment 227085] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 130165: RenderTextControl depends on OS X-specific behavior
https://bugs.webkit.org/show_bug.cgi?id=130165

Attachment 227085: Patch
https://bugs.webkit.org/attachment.cgi?id=227085&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227085&action=review


> Source/WebCore/ChangeLog:3
> +	   RenderTextControl switches on OSX behavior

Please change bug title to "RenderTextControl does not need iOS-specific
behavior"

> Source/WebCore/ChangeLog:18
> +	   * platform/graphics/Font.cpp:
> +	   (WebCore::Font::hasValidAverageCharWidth):
> +	   (WebCore::Font::fastAverageCharWidthIfAvailable):

You should describe what you did here, because it isn't removing
platform-specific code, or at least doesn't look like it is.

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:-354
> -    // For text inputs, IE adds some extra width.
> -    if (maxCharWidth > 0.f)
> -	   result += maxCharWidth - charWidth;

How do we know we can get rid of this too?