[webkit-reviews] review denied: [Bug 125565] visibility:hidden can't hide an iframe if its elements been set as -webkit-transform:translate3d : [Attachment 227042] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Manish Gurnaney
<manishgurnaney at gmail.com>'s request for review:
Bug 125565: visibility:hidden can't hide an iframe if its elements been set as
-webkit-transform:translate3d
https://bugs.webkit.org/show_bug.cgi?id=125565

Attachment 227042: Patch
https://bugs.webkit.org/attachment.cgi?id=227042&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227042&action=review


> Source/WebCore/rendering/RenderIFrame.cpp:66
>  bool RenderIFrame::requiresLayer() const
>  {
> -    return RenderFrameBase::requiresLayer() || style().resize() !=
RESIZE_NONE;
> +    return (style().visibility() == VISIBLE ||
style().hasOutOfFlowPosition())
> +	   && (RenderFrameBase::requiresLayer() || style().resize() !=
RESIZE_NONE);
>  }

This is the wrong place. This is about RenderLayer creation, not compositing
(GraphicsLayer) creation.

RenderLayerCompositor::requiresCompositingForFrame() is the one you should
change.