[webkit-reviews] review granted: [Bug 130358] Make Remote Control commands testable : [Attachment 227050] Proposed patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 130358: Make Remote Control commands testable
https://bugs.webkit.org/show_bug.cgi?id=130358

Attachment 227050: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=227050&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227050&action=review


r=me, with nit. (and a rebaseline needed)

> Source/WebCore/platform/audio/MediaSessionManager.cpp:207
> +    if (m_sessions.size() < 2)
> +	   return;

This code will skip the ASSERT below if m_sessions is empty.  Should this be:?

ASSERT(m_sessions.size());
if (m_sessions.size() == 1)
    return;