[webkit-reviews] review denied: [Bug 130384] Micro-optimize element descendant iterator. : [Attachment 227023] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Andreas Kling <akling at apple.com>'s
request for review:
Bug 130384: Micro-optimize element descendant iterator.
https://bugs.webkit.org/show_bug.cgi?id=130384

Attachment 227023: Patch
https://bugs.webkit.org/attachment.cgi?id=227023&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=227023&action=review


> Source/WebCore/dom/ElementDescendantIterator.h:38
> +    ElementDescendantIterator& operator++();

It is not correct to just have custom operator++ as rest of the base class
traversal functions will not be stack aware. It is probably better to just get
rid of the base class.