[webkit-reviews] review granted: [Bug 130382] [iOS][WebKit2] <rdar://problem/16330387> Do not use the keyboard rect for computing the general unobscuredRect, only use it for centering : [Attachment 227003] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 22:28:16 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 130382: [iOS][WebKit2] <rdar://problem/16330387> Do not use the keyboard
rect for computing the general unobscuredRect, only use it for centering
https://bugs.webkit.org/show_bug.cgi?id=130382

Attachment 227003: Patch
https://bugs.webkit.org/attachment.cgi?id=227003&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227003&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:632
> +- (CGRect)_unobscuredContentRectIncludingKeyboard

This name is confusing. Does the unobscuring include or exclude the keyboard?


More information about the webkit-reviews mailing list