[webkit-reviews] review requested: [Bug 130377] Web Inspector: sourceMapResourceLoaded expects statusCode parameter : [Attachment 226992] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 18:07:24 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 130377: Web Inspector: sourceMapResourceLoaded expects statusCode parameter
https://bugs.webkit.org/show_bug.cgi?id=130377

Attachment 226992: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=226992&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Harmless, but nice cleanup.

Context:
...
82:	   function sourceMapResourceLoaded(error, body, mimeType, statusCode)
83-	   {
84-	       const base64encoded = false;
85-
86-	       if (error || statusCode >= 400) {
87-		   this.markAsFailed();
...

js> undefined >= 400
false


More information about the webkit-reviews mailing list