[webkit-reviews] review granted: [Bug 130355] Add SPI for getting bundle parameters from the injected bundle : [Attachment 226947] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 130355: Add SPI for getting bundle parameters from the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=130355

Attachment 226947: Patch
https://bugs.webkit.org/attachment.cgi?id=226947&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
>+    _parameters = adoptNS([[NSMutableDictionary alloc]
initWithDictionary:dictionary]);

Is this better than -mutableCopy?

> 
> #if USE(FOUNDATION)
> OBJC_CLASS NSBundle;
>+OBJC_CLASS NSMutableDictionary;
>+OBJC_CLASS WKWebProcessBundleParameters;

Shouldn’t this be only #if WK_API_ENABLED ?

> 
>+#if PLATFORM(COCOA)
>+    WKWebProcessBundleParameters *bundleParameters();
>+#endif

Ditto.


>+
>+#if PLATFORM(COCOA)
>+    RetainPtr<WKWebProcessBundleParameters> m_bundleParameters;
>+#endif

Ditto.