[webkit-reviews] review canceled: [Bug 126022] [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load : [Attachment 226827] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has canceled Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 126022: [CoordinatedGraphics][WK2] Scale factor and scroll position is not
being restored properly in a back/forward load
https://bugs.webkit.org/show_bug.cgi?id=126022

Attachment 226827: Patch
https://bugs.webkit.org/attachment.cgi?id=226827&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226827&action=review


> The problem on EFL port seems to be on the PageViewportController, it is
setting the scale to 1 every time the page is loaded in didRenderFrame method

This problem is not fixed by this patch yet. Let me check it soon.

>> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:104
>> +
> 
> I think we don't need this callback, due to
http://trac.webkit.org/changeset/162382.
> updateViewportSize() call can be moved to WebView::setContentScaleFactor.

> I think we don't need this callback, due to
http://trac.webkit.org/changeset/162382.
Looks like that. r162382 already updates m_pageScaleFactor with new scale
factor. I will remove it.