[webkit-reviews] review granted: [Bug 130182] [EFL][WK2] Restore cursor when moving mouse into webview : [Attachment 226899] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 04:21:45 PDT 2014


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 130182: [EFL][WK2] Restore cursor when moving mouse into webview
https://bugs.webkit.org/show_bug.cgi?id=130182

Attachment 226899: Patch
https://bugs.webkit.org/attachment.cgi?id=226899&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226899&action=review


LGTM now.

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:492
> +    if (cursor.image()) {

Trivial recommendation : How about using isNull() explicitly as below ?

!cursor.image()->isNull()


More information about the webkit-reviews mailing list