[webkit-reviews] review requested: [Bug 130241] Refactor checking log channel state in MediaPlayerPrivateGStreamerBase. : [Attachment 226902] patch - fixed style
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 17 04:10:29 PDT 2014
Peter Molnar <pmolnar.u-szeged at partner.samsung.com> has asked for review:
Bug 130241: Refactor checking log channel state in
MediaPlayerPrivateGStreamerBase.
https://bugs.webkit.org/show_bug.cgi?id=130241
Attachment 226902: patch - fixed style
https://bugs.webkit.org/attachment.cgi?id=226902&action=review
------- Additional Comments from Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>
(In reply to comment #4)
> Attachment 226901 [details] did not pass style-queue:
>
>
> ERROR: Source/WebCore/platform/Logging.h:83: Code inside a namespace should
not be indented. [whitespace/indent] [4]
I'm not quite sure about this style error. The exactly same change in this file
passed a few days ago. Someone upgraded the stlye checker? :)
Should I fix the indentation in the whole file, even the lines not touched by
this patch?
> ERROR: Source/WebCore/platform/Logging.cpp:53: Else clause should never be
on same line as else (use 2 lines) [whitespace/newline] [4]
Fixed.
More information about the webkit-reviews
mailing list