[webkit-reviews] review canceled: [Bug 130241] Refactor checking log channel state in MediaPlayerPrivateGStreamerBase. : [Attachment 226723] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 03:30:55 PDT 2014


Peter Molnar <pmolnar.u-szeged at partner.samsung.com> has canceled Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>'s request for review:
Bug 130241: Refactor checking log channel state in
MediaPlayerPrivateGStreamerBase.
https://bugs.webkit.org/show_bug.cgi?id=130241

Attachment 226723: patch
https://bugs.webkit.org/attachment.cgi?id=226723&action=review

------- Additional Comments from Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>
(In reply to comment #2)
> (From update of attachment 226723 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=226723&action=review
> 
> > Source/WebCore/platform/Logging.cpp:50
> > +	 WTFLogChannel* channel = WTFLogChannelByName(logChannels,
logChannelCount, name.utf8().data());
> 
> Would be good to check the channel is not null.

Added null check.


More information about the webkit-reviews mailing list