[webkit-reviews] review denied: [Bug 129802] [GTK] Don't busy loop when the socket is full : [Attachment 225992] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Giovanni Campagna
<scampa.giovanni at gmail.com>'s request for review:
Bug 129802: [GTK] Don't busy loop when the socket is full
https://bugs.webkit.org/show_bug.cgi?id=129802

Attachment 225992: Patch
https://bugs.webkit.org/attachment.cgi?id=225992&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225992&action=review


Thanks for the patch. This patch needs a ChangeLog, see
http://www.webkit.org/coding/contributing.html.

> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:37
> +#include <poll.h>

Is this available in all UNIX platforms?

> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:535
> +	       poll(&pollfd, 1, -1);
> +	   }

Does this really work? Don't you need to continue the loop when poll returns?