[webkit-reviews] review granted: [Bug 124128] [regression] foreign content not displayed in MathML : [Attachment 226883] Fix <annotation>

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Frédéric Wang <fred.wang at free.fr>'s
request for review:
Bug 124128: [regression] foreign content not displayed in MathML
https://bugs.webkit.org/show_bug.cgi?id=124128

Attachment 226883: Fix <annotation>
https://bugs.webkit.org/attachment.cgi?id=226883&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226883&action=review


Patch looks fine, but I don’t think our test coverage is sufficient. There are
multiple changes here that I believe are untested.

> Source/WebCore/ChangeLog:8
> +	   No new tests.

No point in saying "no new tests". We should delete this line if we have
nothing to say about tests.

If there is a good reason we don’t need tests for this patch even though the
patch fixes a bug, then please give that reason in the change log.