[webkit-reviews] review granted: [Bug 102853] [EFL][WK2] Add ewk_application_cache_manager APIs : [Attachment 226882] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 16 22:36:07 PDT 2014
Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 102853: [EFL][WK2] Add ewk_application_cache_manager APIs
https://bugs.webkit.org/show_bug.cgi?id=102853
Attachment 226882: Patch
https://bugs.webkit.org/attachment.cgi?id=226882&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226882&action=review
LGTM except for a wrong description.
> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.h:73
> + * @return @c EINA_TRUE on successful request or @c EINA_FALSE on failure
This API returns *void*, not boolean.
More information about the webkit-reviews
mailing list