[webkit-reviews] review granted: [Bug 130313] Use RunLoop objects through references instead of pointers : [Attachment 226863] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 16 15:57:35 PDT 2014


Andreas Kling <akling at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 130313: Use RunLoop objects through references instead of pointers
https://bugs.webkit.org/show_bug.cgi?id=130313

Attachment 226863: Patch
https://bugs.webkit.org/attachment.cgi?id=226863&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
/Volumes/Data/EWS/WebKit/Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:447:
28: error: member reference type 'WTF::RunLoop' is not a pointer
	   
m_clientRunLoop->dispatch(bind(&Connection::dispatchDidReceiveInvalidMessage,
this, decoder->messageReceiverName().toString(),
decoder->messageName().toString()));
	    ~~~~~~~~~~~~~~~^

r=me once you get it to build :)


More information about the webkit-reviews mailing list