[webkit-reviews] review granted: [Bug 130310] Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject : [Attachment 226857] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 16 14:14:56 PDT 2014


Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 130310: Explicitly include cstdio header for debug builds in InlineTextBox,
RenderLayer, RenderObject
https://bugs.webkit.org/show_bug.cgi?id=130310

Attachment 226857: Patch
https://bugs.webkit.org/attachment.cgi?id=226857&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I don’t think these includes should be inside #if statements. I also think it’s
a little strange that we include <cstdio> rather than <stdio.h> since we call
the function fprintf, not std::fprintf.


More information about the webkit-reviews mailing list