[webkit-reviews] review granted: [Bug 130304] Remove all uses of deprecatedCharacters from JavaScriptCore : [Attachment 226842] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 16 10:32:32 PDT 2014
Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 130304: Remove all uses of deprecatedCharacters from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=130304
Attachment 226842: Patch
https://bugs.webkit.org/attachment.cgi?id=226842&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226842&action=review
> Source/JavaScriptCore/API/JSValueRef.cpp:336
> + if (str.is8Bit()) {
I think this will crash if str is a null string.
More information about the webkit-reviews
mailing list