[webkit-reviews] review denied: [Bug 15795] [GTK] Change the mouse pointer state to busy while loading a page : [Attachment 225352] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 16 03:57:44 PDT 2014


Philippe Normand <pnormand at igalia.com> has denied Diego Pino
<dpino at igalia.com>'s request for review:
Bug 15795: [GTK] Change the mouse pointer state to busy while loading a page
https://bugs.webkit.org/show_bug.cgi?id=15795

Attachment 225352: Patch
https://bugs.webkit.org/attachment.cgi?id=225352&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225352&action=review


> Tools/MiniBrowser/gtk/BrowserWindow.c:485
> +    GdkWindow *gdk_window =
gtk_widget_get_window(GTK_WIDGET(window->webView));

We use camelCase here, I think. So, gdkWindow ?

> Tools/MiniBrowser/gtk/BrowserWindow.c:493
> +	   gdk_window_set_cursor(gdk_window, lastCursor);

I suppose it's alright to not check lastCursor is non-null here, right? Passing
NULL means use the cursor of the parent window.


More information about the webkit-reviews mailing list