[webkit-reviews] review granted: [Bug 130297] Double values passed to fabsf() in maxScaleFromTransform() : [Attachment 226832] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 130297: Double values passed to fabsf() in maxScaleFromTransform()
https://bugs.webkit.org/show_bug.cgi?id=130297

Attachment 226832: Patch v1
https://bugs.webkit.org/attachment.cgi?id=226832&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226832&action=review


> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287
> +    return std::max(fabsf(static_cast<float>(decomposeData.scaleX)),
fabsf(static_cast<float>(decomposeData.scaleY)));

I’d really prefer we use syntax cast for casting double to float that would not
also work to convert, say, int to float.