[webkit-reviews] review granted: [Bug 130294] Move BorderEdge class to its own file. : [Attachment 226826] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 130294: Move BorderEdge class to its own file.
https://bugs.webkit.org/show_bug.cgi?id=130294

Attachment 226826: Patch
https://bugs.webkit.org/attachment.cgi?id=226826&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226826&action=review


> Source/WebCore/rendering/BorderEdge.h:49
> +    BorderEdge(LayoutUnit edgeWidth, const Color& edgeColor, EBorderStyle
edgeStyle, bool edgeIsTransparent, bool edgeIsPresent, float devicePixelRatio);


I wonder how much sense it makes to pass Color by reference (rather than by
value) these days.