[webkit-reviews] review granted: [Bug 130284] Rewrite WebHTMLConverter::_getComputedFloat in C++ : [Attachment 226805] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 15 14:42:02 PDT 2014


Andreas Kling <akling at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 130284: Rewrite WebHTMLConverter::_getComputedFloat in C++
https://bugs.webkit.org/show_bug.cgi?id=130284

Attachment 226805: Patch
https://bugs.webkit.org/attachment.cgi?id=226805&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226805&action=review


> Source/WebCore/platform/mac/HTMLConverter.mm:769
> +	   if (Node* parent = node.parentNode())

This is really a ContainerNode*.

> Source/WebCore/platform/mac/HTMLConverter.mm:802
> +	   if (Node* parent = node.parentNode())

This is really a ContainerNode*.


More information about the webkit-reviews mailing list