[webkit-reviews] review granted: [Bug 130286] Fix build: using integer absolute value function 'abs' when argument is of floating point type : [Attachment 226808] Patch v1

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 130286: Fix build: using integer absolute value function 'abs' when
argument is of floating point type
https://bugs.webkit.org/show_bug.cgi?id=130286

Attachment 226808: Patch v1
https://bugs.webkit.org/attachment.cgi?id=226808&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226808&action=review


R=me to fix build.  Leaving cq? alone in case you want to land the fabs()
change instead.  Calling abs() and casting to int means we miss a *bunch* of
blinding opportunities.

> Source/JavaScriptCore/assembler/MacroAssembler.h:992
> -	   value = abs(value);
> +	   value = abs(static_cast<int>(value));

I strongly suspect that we meant to call fabs instead.