[webkit-reviews] review denied: [Bug 130123] Incorrect Date returned between March 1, 2034 and February 28, 2100. : [Attachment 226779] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied Byungseon Shin <xingri at gmail.com>'s
request for review:
Bug 130123: Incorrect Date returned between March 1, 2034 and  February 28,
2100.
https://bugs.webkit.org/show_bug.cgi?id=130123

Attachment 226779: Patch
https://bugs.webkit.org/attachment.cgi?id=226779&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226779&action=review


Almost there. =)  Please fix the remaining issues.  For your updated patch,
mark it cq? if you need it to be committed via the commit-queue.

> LayoutTests/js/script-tests/date-constructor.js:81
> +	   shouldBe(“new Date(“ + dateString + “).getFullYear()”,
year);

Please use the ascii double quote character ‘“' instead of '‒.

> LayoutTests/js/script-tests/date-constructor.js:84
> +	   shouldBe(“new Date(“ + dateString + “).getMonth()”, month);

Ditto.

> LayoutTests/js/script-tests/date-constructor.js:87
> +	   shouldBe(“new Date(“ + dateString + “).getDate()”, date);

Ditto.