[webkit-reviews] review granted: [Bug 130267] Begin work on the bundle parameter API : [Attachment 226771] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 130267: Begin work on the bundle parameter API
https://bugs.webkit.org/show_bug.cgi?id=130267

Attachment 226771: Patch
https://bugs.webkit.org/attachment.cgi?id=226771&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226771&action=review


> Source/WebKit2/Shared/WebProcessCreationParameters.h:39
> +

Why?

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:198
> +	   [keyedArchiver setRequiresSecureCoding:YES];

This may not compile on Mountain Lion, where -setRequiresSecureCoding: was not
declared in an API header.

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:202
> +	       [keyedArchiver encodeObject:m_bundleParameters.get()
forKey:@"parameters"];
> +	       [keyedArchiver finishEncoding];

Why not just send -encodeWithCoder: to the dictionary? Then we don’t need the
@"parameters" key.