[webkit-reviews] review granted: [Bug 130261] [GTK][CMake] Build with -fno-rtti : [Attachment 226763] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 14 14:16:43 PDT 2014


Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 130261: [GTK][CMake] Build with -fno-rtti
https://bugs.webkit.org/show_bug.cgi?id=130261

Attachment 226763: Patch
https://bugs.webkit.org/attachment.cgi?id=226763&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226763&action=review


> Source/cmake/gtest/CMakeLists.txt:25
> +add_definitions(-DGTEST_CREATE_SHARED_LIBRARY=1 -DGTEST_HAS_RTTI=0)

New line please.

> Tools/TestWebKitAPI/CMakeLists.txt:89
> +add_definitions(-DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DGTEST_HAS_RTTI=0

New line please.


More information about the webkit-reviews mailing list