[webkit-reviews] review granted: [Bug 130103] Improve dom error messages : [Attachment 226735] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 130103: Improve dom error messages
https://bugs.webkit.org/show_bug.cgi?id=130103

Attachment 226735: Patch
https://bugs.webkit.org/attachment.cgi?id=226735&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226735&action=review


r=me, please fix Windows build.

> Source/JavaScriptCore/runtime/Error.h:73
> +    inline EncodedJSValue throwVMTypeError(ExecState* exec, String
errorMessage) { return JSValue::encode(throwTypeError(exec, errorMessage)); }

'errorMessage' will have unnecessary ref count churn here.

> Source/WebCore/bindings/js/JSDOMBinding.h:651
> +#define makeDOMBindingsTypeErrorString(...)
makeDOMBindingsTypeErrorStringInternal(__VA_ARGS__, (const char*)0)

0->nullptr