[webkit-reviews] review canceled: [Bug 129740] [EFL] Add WK2 API to control TLS error policy on WebContext. : [Attachment 226289] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 14 05:51:12 PDT 2014


Peter Molnar <pmolnar.u-szeged at partner.samsung.com> has canceled Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>'s request for review:
Bug 129740: [EFL] Add WK2 API to control TLS error policy on WebContext.
https://bugs.webkit.org/show_bug.cgi?id=129740

Attachment 226289: patch
https://bugs.webkit.org/attachment.cgi?id=226289&action=review

------- Additional Comments from Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>
(In reply to comment #15)
> (From update of attachment 226289 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=226289&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_context.h:362
> > +Eina_Bool ewk_context_ignore_tls_errors_get(const Ewk_Context
*ewkContext);
> 
> Regarding the naming, I would suggest
'ewk_context_tls_errors_policy_get/set()' and to add a enumeration for TLS
errors policy(Ignore/Fail). 
> As described in comments, this API provides the interface to control the TLS
error policy.

Yes, this name is definitely better, I've renamed it. Also added the
enumeration you suggested.

> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:115
> > +	     if (!strcmp(path, "/index.html")) {
> 
> Why don't you use strncmp() instead of strcmp()?

Currently strcmp() is used in all of these tests, so I'm trying to conform to
this here, too. If you think it needs to be an strncmp(), then it would be wise
to change it in all of the other tests also.


More information about the webkit-reviews mailing list