[webkit-reviews] review granted: [Bug 130210] Build fix with SUBPIXEL_LAYOUT disabled : [Attachment 226623] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 13 23:46:30 PDT 2014


Daniel Bates <dbates at webkit.org> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 130210: Build fix with SUBPIXEL_LAYOUT disabled
https://bugs.webkit.org/show_bug.cgi?id=130210

Attachment 226623: Patch
https://bugs.webkit.org/attachment.cgi?id=226623&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226623&action=review


> Source/WebCore/ChangeLog:8
> +	   Fixing increment operation in LayoutUnit value.

Although the change is straightforward, I suggest elaborating on the what is
being fixed and why. Maybe something like:

Use pre-incremeent operator for LayoutUnit instead of post-increment operator
as LayoutUnit doesn't support the latter and we don't make use of the return
value.


More information about the webkit-reviews mailing list