[webkit-reviews] review granted: [Bug 130223] Move visited link handling to VisitedLinkTableController and VisitedLinkProvider : [Attachment 226648] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 130223: Move visited link handling to VisitedLinkTableController and
VisitedLinkProvider
https://bugs.webkit.org/show_bug.cgi?id=130223

Attachment 226648: Patch
https://bugs.webkit.org/attachment.cgi?id=226648&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226648&action=review


> Source/WebKit2/ChangeLog:26
> +	   add the VisitedLinkProvider	object as a message receiver and send
the visited link table to the process.

extra space

> Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:180
> +	   ASSERT(currentTableMemory->size() == m_tableSize *
sizeof(LinkHash));

This isn’t right

> Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:192
> +	       if (!m_table.addLinkHash(linkHash))
> +		   ASSERT_NOT_REACHED();

It’s nicer to use a local bool and ASSERT_UNUSED in such cases.

> Source/WebKit2/UIProcess/VisitedLinkProvider.messages.in:1
> +# Copyright (C) 2011 Apple Inc. All rights reserved.

2011?

> Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.h:52
> +    void visitedLinkStateChanged(const Vector<WebCore::LinkHash>&
linkHashes);

Don’t need to name this parameter.

> Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.messages.in:1
> +# Copyright (C) 2011 Apple Inc. All rights reserved.

2011 again?