[webkit-reviews] review granted: [Bug 130218] The viewport code should not depend on WebKitSystemInterface : [Attachment 226630] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 13 17:10:13 PDT 2014


Tim Horton <thorton at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 130218: The viewport code should not depend on WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=130218

Attachment 226630: Patch
https://bugs.webkit.org/attachment.cgi?id=226630&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226630&action=review


> Source/WebCore/page/ChromeClient.h:179
> +    virtual FloatSize viewportScreenSize() const { return
const_cast<ChromeClient*>(this)->windowRect().size(); }

:| const_cast!


More information about the webkit-reviews mailing list