[webkit-reviews] review denied: [Bug 129803] text selection highlight is visually incorrect under heavy padding constraints : [Attachment 226101] Patch proposal

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 129803: text selection highlight is visually incorrect under heavy padding
constraints
https://bugs.webkit.org/show_bug.cgi?id=129803

Attachment 226101: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=226101&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226101&action=review


>
LayoutTests/platform/mac/editing/selection/inline-closest-leaf-child-expected.t
xt:35
> -selection start: position 2 of child 0 {#text} of child 1 {SPAN} of child 4
{DIV} of body
> -selection end:   position 5 of child 2 {#text} of child 1 {SPAN} of child 4
{DIV} of body
> +caret: position 0 of child 0 {#text} of child 1 {SPAN} of child 4 {DIV} of
body

Looks like this is a regression. r- due to the lack of description as to why
new result is correct.