[webkit-reviews] review granted: [Bug 129926] Add Remote Control command support to HTMLMediaElement : [Attachment 226172] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 129926: Add Remote Control command support to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=129926

Attachment 226172: Patch
https://bugs.webkit.org/attachment.cgi?id=226172&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226172&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:3059
> +    } else
> +	   setPlaybackRate(nextScanRate());
> +}

Do we really want to increase the scan rate to infinity (and beyond)?

> Source/WebCore/html/HTMLMediaElement.cpp:5937
> +	   { } // Do nothing

Nit: I don't think "{ }" is necessary, won't a semi-colon work?