[webkit-reviews] review granted: [Bug 130172] [iOS] Sync media playback with now playing : [Attachment 226569] Proposed patch.

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 130172: [iOS] Sync media playback with now playing
https://bugs.webkit.org/show_bug.cgi?id=130172

Attachment 226569: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=226569&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226569&action=review


r=me

> Source/WebCore/platform/audio/MediaSessionManager.cpp:157
> -
> +    

Whew, I was worried I wouldn't have a nit!  Ahem, unnecessary whitespace.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:42
> +#import <MediaPlayer/MPRemoteCommand.h>
> +#import <MediaPlayer/MPRemoteCommandCenter.h>
> +#import <MediaPlayer/MPRemoteCommandEvent.h>

It looks like these are unused.  (For now.)

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:71
> +SOFT_LINK_CLASS(MediaPlayer, MPRemoteCommandCenter)

Ditto.