[webkit-reviews] review granted: [Bug 129369] AX: accessibility data table heuristics fail on this jQuery table : [Attachment 226577] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 129369: AX: accessibility data table heuristics fail on this jQuery table
https://bugs.webkit.org/show_bug.cgi?id=129369

Attachment 226577: patch
https://bugs.webkit.org/attachment.cgi?id=226577&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226577&action=review


This new heuristic makes sense to me. Just please consider the nits below +
James's comment before landing

> Source/WebCore/ChangeLog:14
> +	   (WebCore::AccessibilityRenderObject::activeDescendant):

The changes here seem to be unrelated to the patch, but I'm ok anyway as I
don't think filing a new bug for those is worth it.

> Source/WebCore/accessibility/AccessibilityTable.cpp:140
> +	   // if there is a caption element, summary, THEAD, or TFOOT section,
it's most certainly a data table.

"if"->"If" (yes, I know it's just re-indented code :-))

> Source/WebCore/accessibility/AccessibilityTable.cpp:144
> +	   // if someone used "rules" attribute than the table should appear

"if"->"If" / "than"->"then" / missing period at the end

> Source/WebCore/accessibility/AccessibilityTable.cpp:148
> +	   // if there's a colgroup or col element, it's probably a data table.


"if"->"If"